fix: Duplicate region in Snowflake URI no longer breaks OpenLineage#50831
Merged
mobuchowski merged 1 commit intoapache:mainfrom May 21, 2025
Merged
fix: Duplicate region in Snowflake URI no longer breaks OpenLineage#50831mobuchowski merged 1 commit intoapache:mainfrom
mobuchowski merged 1 commit intoapache:mainfrom
Conversation
mobuchowski
approved these changes
May 20, 2025
4500b2f to
7aae3b9
Compare
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
May 21, 2025
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When debugging another issue, I came across some examples of Snowflake URI that will still execute the query, but break OpenLineage. Duplicated region in hostname seems to be ignored by Snowflake, but is causing OL to crash as we expect exactly 3 elements - locator, region, cloud.
This PR adjusts OL behaviour, so that it's consistent with Snowflake. This should only happen when user provides duplicate information in uri (f.e. region in account and also as separate argument). These are some examples of URIs that broke OL but still executed the query:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.